[PATCH] D108877: [WebAssembly] Allow import and export of TLS symbols between DSOs

Wed Sep 8 05:02:21 PDT 2021

sbc100 added inline comments.

================
Comment at: lld/wasm/Writer.cpp:990
+      if (config->sharedMemory) {
+        WasmSym::applyGlobalTLSRelocs = symtab->addSyntheticFunction(
+            "__wasm_apply_global_tls_relocs", WASM_SYMBOL_VISIBILITY_HIDDEN,
----------------
dschuff wrote:
> what if we have TLS in the input but not config->sharedMemory?
In this case all the TLS handling is basically internalize.

See `lld/test/wasm/tls-non-shared-memory.s`.   I've added an extra case to that test to verify that the imported/GOT usage of the TLS variable is also internalized.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108877/new/

https://reviews.llvm.org/D108877