[PATCH] D107421: [yaml2obj][XCOFF] Customize the string table.

Wed Sep 8 03:27:29 PDT 2021

Esme added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/XCOFF/string-table.yaml:269
+
+## Case 17: use the value of the `Length` field for the first 4 bytes of the table.
+# RUN: yaml2obj --docnum=1 %s -DSYMNAME='nameInStrTbl' -DSYMNAME2='name2InStrTbl' \
----------------
jhenderson wrote:
> Probably point out that in this case, the Length value is less than the true length?
> 
> Remind me: does the Length value include the size of the Length field itself? If not, this value looks too large for what is reported in the StringTable.
Yes, the Length value includes the size of the Length field itself.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107421/new/

https://reviews.llvm.org/D107421