[PATCH] D109377: Integer type legalization for vp_load and vp_store.

Wed Sep 8 03:04:27 PDT 2021

frasercrmck added a comment.

In D109377#2987751 <https://reviews.llvm.org/D109377#2987751>, @craig.topper wrote:

> In D109377#2987666 <https://reviews.llvm.org/D109377#2987666>, @hussainjk wrote:
>
>> Hm how test? Selection doesn't work at this point.
>
> Didn't D108999 <https://reviews.llvm.org/D108999> add Selection for RISCV?

Yes you should be able to test this with RISCV. Anything that's not i1/i8/i16/i32 but is less than i64 will need promoting. Also see D108288 <https://reviews.llvm.org/D108288> for examples.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1875
+  if (OpNo >= 4) {
+    // The Mask or EVL. Update in place.
+    EVT DataVT = DataOp.getValueType();
----------------
I don't think we expect EVL to need promoting - do we? It should always be a legal target-specific type, reported by `TLI.getVPExplicitVectorLengthTy()`. I don't know how well we're asserting on that right now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109377/new/

https://reviews.llvm.org/D109377