[PATCH] D109252: Add extra check for llvm::Any::TypeId visibility

[serge via Phabricator via llvm-commits]

serge-sans-paille marked 2 inline comments as done.
serge-sans-paille added inline comments.


================
Comment at: llvm/tools/llvm-shlib/typeid.pattern:2
+# Make sure there's no llvm::Any::TypeId symbol local to the shared library.
+# That would cause non-unicity of the adresses used as unique identifier for
+# each type when another library is linked in with default visibility (weak)
----------------
MaskRay wrote:
> I haven't heard of non-unicity.
> 
> breaking pointer equality is more common.
This really sounds the same to me :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109252/new/

https://reviews.llvm.org/D109252