[PATCH] D102277: [llvm-objcopy][NFC] Refactor CopyConfig structure - categorize options.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 00:20:08 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

One nit, otherwise this looks good to me.



================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:147
 
-static Error processLoadCommands(const CommonConfig &Config, Object &Obj) {
+static Error processLoadCommands(const CommonConfig &,
+                                 const MachOConfig &MachOConfig, Object &Obj) {
----------------
If the `CommonConfig` isn't used anymore, it seems like you could drop the parameter here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102277/new/

https://reviews.llvm.org/D102277



More information about the llvm-commits mailing list