[PATCH] D107923: [X86] X86DAGToDAGISel::matchBitExtract(): support 'num high bits to clear' pattern

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 21:13:09 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:3401
+                                             Optional<bool> AllowExtraUses) {
+    if (AllowExtraUses == None)
+      AllowExtraUses = AllowExtraUsesByDefault;
----------------
Can we use Optional::getValueOr here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107923/new/

https://reviews.llvm.org/D107923



More information about the llvm-commits mailing list