[PATCH] D109243: [GlobalISel] Build_vector_trunc artifact combine into bitcast

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:1198
+
+    MachineInstr *SecoldElt = getDefIgnoringCopies(MI.getReg(2), MRI);
+    if (!SecoldElt || !isa<GImplicitDef>(SecoldElt))
----------------
Typo Secold


================
Comment at: llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:111
   case TargetOpcode::G_BUILD_VECTOR:
+  case TargetOpcode::G_BUILD_VECTOR_TRUNC:
   case TargetOpcode::G_EXTRACT:
----------------
I'm not sure this is really an artifact. You never strictly need it to link 2 operations together, although you can use it to legalize G_BUILD_VECTOR


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109243/new/

https://reviews.llvm.org/D109243