[PATCH] D109241: [GlobalISel] Build_vector artifact combine into unmerge_values

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:1065
 
+  static bool isMergeOrUnmergeCompatible(LLT LargeTy, LLT SmallTy) {
+    if (!LargeTy.isVector() || !SmallTy.isVector())
----------------
Needs a comment. Also is misleading. What does it mean by merge exactly? Is this supposed to cover G_CONCAT_VECTORS?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109241/new/

https://reviews.llvm.org/D109241