[PATCH] D109393: [asan] Changed the label for error reporting code to use GOT instead of PLT.

[Kirill Stoimenov via Phabricator via llvm-commits]

kstoimenov added a comment.

In D109393#2988029 <https://reviews.llvm.org/D109393#2988029>, @pcc wrote:

> In D109393#2987973 <https://reviews.llvm.org/D109393#2987973>, @kstoimenov wrote:
>
>> In D109393#2987961 <https://reviews.llvm.org/D109393#2987961>, @pcc wrote:
>>
>>> What's the effect on the relocation types in the object file with this change? I don't think it's valid to have a branch with an `@GOT` modifier.
>>
>> Moving from PTL to GOT fixed this errors like this: "error: 32 bit reloc applied to a field with a different size". What  do you thing should be the right type for this? Not specifying PTL also had problems with linking so living in blank is not an option.
>
> I mean what's the difference in output of `objdump -dr file.o` before and after.

Before it was like this:

  28:   e9 00 00 00 00          jmpq   2d <__asan_check_store2_rn53+0x2d>
                        29: R_X86_64_PLT32      __asan_report_store2-0x4

With the new flag it is like this:

  28:   e9 00 00 00 00          jmpq   2d <__asan_check_store2_rn53+0x2d>
                        29: R_X86_64_GOTPC32    __asan_report_store2-0x4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109393/new/

https://reviews.llvm.org/D109393