[PATCH] D109400: [LLD] Add archive Name to relocaiton overflow printout

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 16:17:14 PDT 2021


ayermolo added a comment.

In D109400#2988198 <https://reviews.llvm.org/D109400#2988198>, @MaskRay wrote:

> `toString(file)` already contains the archive name.

Well yes, but it's only used when srcFile is not found. When it is found what is printed is:
ld.lld: error: foo.cpp:(.section_name+0x6): relocation <rest of the message>
With this change when srcFile is found output is similar to what toString(file) returns. Except instead of object file name it will be srcFile.

Now maybe whole thing can be simplified and toString(file) can just be used in general?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109400/new/

https://reviews.llvm.org/D109400



More information about the llvm-commits mailing list