[PATCH] D109053: [BitcodeReader] Delay select until all constants resolved

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:2358
+    Type *OpTy;
+    Type *SelectorTy;
+    uint64_t Op0Idx;
----------------
SelectorTy is always i1; no need to store it here.


================
Comment at: llvm/lib/Bitcode/Reader/ValueList.cpp:155
     ResolveConstants.pop_back();
-
+    if (Placeholder == RealVal)
+      continue;
----------------
Why is this change necessary?  If we're sticking a value into ResolveConstants that isn't a placeholder, something has gone wrong, I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109053/new/

https://reviews.llvm.org/D109053