[PATCH] D108656: [IROutliner] Using Canonical Values to find Corresponding Items between Regions

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 14:52:36 PDT 2021


paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:173
+  Optional<Value *> FoundValueOpt = Other.Candidate->fromGVN(*FirstGVN);
+  if (!FoundValueOpt.hasValue())
+    return nullptr;
----------------
I think you can return `FoundValueOpt.getValueOr(nullptr)`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108656/new/

https://reviews.llvm.org/D108656



More information about the llvm-commits mailing list