[PATCH] D106993: [IROutliner] Outline across branches with multiple exits

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

I think this looks fine with a nit on a comment.



================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:146
 
+/// A function to sort the keys of \p Map, if it contains constants, and
+/// return it in \p SortedKeys
----------------
So this isn't really //if// it has constants, right? This actually expects all constants. Maybe this comment should reflect that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106993/new/

https://reviews.llvm.org/D106993