[PATCH] D109395: IR: move the declaration of `VerifyDomInfo` (NFC)

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 14:46:33 PDT 2021


compnerd created this revision.
compnerd added reviewers: sepavloff, rnk.
compnerd added a project: LLVM.
Herald added a subscriber: dexonsmith.
compnerd requested review of this revision.

This moves the declaration of `VerifyDomInfo` into
`llvm/IR/Dominators.h` from `llvm/Support/Debug.h`.  Although this is a
debugging utility, the definition of the symbol is in LLVMIR, not in
LLVMSupport.  This moves the declaration to the containing modules'
header.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109395

Files:
  llvm/include/llvm/IR/Dominators.h
  llvm/include/llvm/Support/Debug.h


Index: llvm/include/llvm/Support/Debug.h
===================================================================
--- llvm/include/llvm/Support/Debug.h
+++ llvm/include/llvm/Support/Debug.h
@@ -85,10 +85,6 @@
 /// turning the checks on without need to recompile.
 /// \{
 
-/// Enables verification of dominator trees.
-///
-extern bool VerifyDomInfo;
-
 /// Enables verification of loop info.
 ///
 extern bool VerifyLoopInfo;
Index: llvm/include/llvm/IR/Dominators.h
===================================================================
--- llvm/include/llvm/IR/Dominators.h
+++ llvm/include/llvm/IR/Dominators.h
@@ -277,6 +277,12 @@
   PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
 };
 
+/// Enables verification of dominator trees.
+///
+/// This check is expensive and is disabled by default.  `-verify-dom-info`
+/// allows selectively enabling the check without needing to recompile.
+extern bool VerifyDomInfo;
+
 /// Legacy analysis pass which computes a \c DominatorTree.
 class DominatorTreeWrapperPass : public FunctionPass {
   DominatorTree DT;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109395.371196.patch
Type: text/x-patch
Size: 1072 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210907/c34b3c89/attachment.bin>


More information about the llvm-commits mailing list