[PATCH] D107923: [X86] X86DAGToDAGISel::matchBitExtract(): support 'num high bits to clear' pattern

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 13:25:26 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:3576
+    SDValue BitWidthC =
+        CurDAG->getConstant(NVT.getScalarSizeInBits(), DL, MVT::i32);
+    insertDAGNode(*CurDAG, SDValue(Node, 0), BitWidthC);
----------------
craig.topper wrote:
> NVT is a scalar isn't it? So this could just be getSizeINBits()?
Err, right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107923/new/

https://reviews.llvm.org/D107923



More information about the llvm-commits mailing list