[PATCH] D108777: [SystemZ] [NFC] Add SystemZELFFrameLowering and SystemZXPLINKFrameLowering classes.

[Kai Nacke via Phabricator via llvm-commits]

Kai requested changes to this revision.
Kai added a comment.
This revision now requires changes to proceed.

Sorry, after seeing the pre-check builds, I checked the formatting again.
The code looks ok, but almost all function heads with argument lists running over several lines needs reformatting.



================
Comment at: llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp:64
+                              MachineBasicBlock &MBB,
+                              MachineBasicBlock::iterator MI) const {
+  switch (MI->getOpcode()) {
----------------
Formatting looks wrong.


================
Comment at: llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp:79
+bool
+SystemZFrameLowering::hasReservedCallFrame(const MachineFunction &MF) const {
+  // The ELF ABI requires us to allocate 160 bytes of stack space for the 
----------------
Formatting looks wrong.


================
Comment at: llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp:80
+SystemZFrameLowering::hasReservedCallFrame(const MachineFunction &MF) const {
+  // The ELF ABI requires us to allocate 160 bytes of stack space for the 
+  // callee, with any outgoing stack arguments being placed above that. It
----------------
Trailing space at end of line.


================
Comment at: llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp:208
+                           RegSpillOffsets(0) {
+  // Due to the SystemZ ABI, the DWARF CFA (Canonical Frame Address) is not
+  // equal to the incoming stack pointer, but to incoming stack pointer plus
----------------
Formatting seems to be wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108777/new/

https://reviews.llvm.org/D108777