[PATCH] D109385: [X86] Disable muloti4 libcalls for x86-64.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 12:34:58 PDT 2021


craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel, nickdesaulniers, lebedev.ri, efriedma.
Herald added subscribers: pengfei, hiraditya.
craig.topper requested review of this revision.
Herald added a project: LLVM.

This library function only exists in compiler-rt not libgcc. So
this would fail to link unless we were linking with compiler-rt.

This is consistent with the recent removal of calls to mulodi4 on
32-bit targets like D108928 <https://reviews.llvm.org/D108928>.

I suppose maybe we could keep the libcalls for platforms like
Darwin that use compiler-rt exclusively?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109385

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/test/CodeGen/X86/muloti.ll
  llvm/test/CodeGen/X86/smulo-128-legalisation-lowering.ll
  llvm/test/CodeGen/X86/vec_smulo.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109385.371152.patch
Type: text/x-patch
Size: 40265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210907/f8233020/attachment.bin>


More information about the llvm-commits mailing list