[PATCH] D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections

Tue Sep 7 12:27:35 PDT 2021

jrtc27 added a comment.

In D96914#2586099 <https://reviews.llvm.org/D96914#2586099>, @jrtc27 wrote:

> Thanks, having it opt-in for the times it's needed is fine by me (although anyone opting in should of course be careful that it really is safe). Possibly worth a note in the manpage that it's not always safe?

My approval for this change was conditional on it being opt-in. In 6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619> you flipped the default, committing without review. As anticipated, this has broken things in FreeBSD. I don't know the extent of it, @dim can perhaps comment, but I am not impressed by that commit after I specifically told you this had implications for FreeBSD's use of linker sets.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96914/new/

https://reviews.llvm.org/D96914