[PATCH] D109185: [gn build] Add build files for LLDB

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM

In D109185#2987403 <https://reviews.llvm.org/D109185#2987403>, @thakis wrote:

> - rebase
> - add `-sectcreate` flags for embedding Info.plist files into lldb and lldb-vscode
>
> This is probably in shape enough to iterate in in-tree. I didn't squash in your linux change; let's land that separately :)

Okay, sounds good.



================
Comment at: llvm/utils/gn/secondary/lldb/source/Host/BUILD.gn:11
+    "//llvm/utils/gn/build/libs/xml",
+
+    # FIXME:
----------------
Maybe add the missing dependency on //lldb/include/lldb/Host:Config from my patch here? That seems more like a generic dependency problem than something Linux-specific.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109185/new/

https://reviews.llvm.org/D109185