[PATCH] D109376: [OpenMP] Check OpenMP assumptions on call-sites as well

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 11:48:06 PDT 2021


jdoerfert added a comment.

Test missing.



================
Comment at: llvm/include/llvm/IR/Assumptions.h:50
+/// Return true if \p CB has the assumption \p AssumptionStr attached.
+bool hasAssumption(CallBase &CB, const KnownAssumptionString &AssumptionStr);
+
----------------
I think this should check CB and then the callee, if available. So documentation and impl need to change slightly.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3726
+      SPMDCompatibilityTracker.indicateOptimisticFixpoint();
+    }
 
----------------
Once the CB version checks the callee this will be much simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109376/new/

https://reviews.llvm.org/D109376



More information about the llvm-commits mailing list