[PATCH] D106947: [DSE][NFC] Rename Later->Killing, Earlier->Killed

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 11:32:20 PDT 2021


asbirlea added a comment.

[This may be beyond something to address in this patch]  I'm wondering if there should be some consistency between `isPartialOverwrite` and `isCompleteOverwrite`. Both could use "Def" and "Use" naming, or "[Maybe]Dead" and "Killing" naming.

I'm good with the renaming, leaving @fhahn give the green light.



================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:340
+/// overwrite one another. More specifically, \p KillingI has to
+/// overwrite \p DeadII.
+static OverwriteResult isMaskedStoreOverwrite(const Instruction *KillingI,
----------------
s/DeadII/DeadI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106947/new/

https://reviews.llvm.org/D106947



More information about the llvm-commits mailing list