[PATCH] D109377: Integer type legalization for vp_load and vp_store.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Tests?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1871
+  if (OpNo >= 4) {
+    // The Mask||EVL. Update in place.
+    EVT DataVT = DataOp.getValueType();
----------------
Just write the word "or" here instead of the ||.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1873
+    EVT DataVT = DataOp.getValueType();
+    SDValue PromotedOperand = PromoteTargetBoolean(N->getOperand(OpNo), DataVT);
+    SmallVector<SDValue, 5> NewOps(N->op_begin(), N->op_end());
----------------
PromoteTargetBoolean would be incorrect for EVL wouldn't it? EVL should always ZERO_EXTEND right?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1891
+  EVT DataVT = N->getValueType(0);
+  SDValue PromotedOperand = PromoteTargetBoolean(N->getOperand(OpNo), DataVT);
+  SmallVector<SDValue, 5> NewOps(N->op_begin(), N->op_end());
----------------
Same question as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109377/new/

https://reviews.llvm.org/D109377