[PATCH] D109294: [Inline] Remove dead users before checking if function has one use (PR51667)

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:1862
 
+  F.removeDeadConstantUsers();
   bool OnlyOneCallAndLocalLinkage =
----------------
aeubanks wrote:
> mtrofin wrote:
> > From a separation of concerns perspective, I think this should rather happen after a successful inline, rather than when computing cost.
> +1, an analysis shouldn't be changing the IR
This already happens after a successful inline. The problem is that we also need it to happen before the hasOneUse() check below. The operation could be move to the point where the cost model is queried though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109294/new/

https://reviews.llvm.org/D109294