[PATCH] D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 7 08:52:07 PDT 2021
jdoerfert added a comment.
Drive by only.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h:72
+ return packConstantV2I16(N, DAG, true);
+}
+
----------------
FWIW, I would recommend static, or anonymous namespaces rather than inline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109351/new/
https://reviews.llvm.org/D109351
More information about the llvm-commits
mailing list