[PATCH] D109294: [Inline] Remove dead users before checking if function has one use (PR51667)

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:1862
 
+  F.removeDeadConstantUsers();
   bool OnlyOneCallAndLocalLinkage =
----------------
mtrofin wrote:
> From a separation of concerns perspective, I think this should rather happen after a successful inline, rather than when computing cost.
+1, an analysis shouldn't be changing the IR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109294/new/

https://reviews.llvm.org/D109294