[PATCH] D109159: [amdgpu] Enable selection of `s_cselect_b64`.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 08:07:01 PDT 2021


hliao added a comment.

In D109159#2986862 <https://reviews.llvm.org/D109159#2986862>, @foad wrote:

> Just for the record, see also this comment from D82370 <https://reviews.llvm.org/D82370>:
>
>> Additionally, remove pattern for selects with 64-bit
>> inputs, which are rare, because handling them properly
>> requires more thought.
>
> This reverted part of D81925 <https://reviews.llvm.org/D81925>, which originally added both 32- and 64-bit patterns.

In fact, we found that 64-bit select is not rare, partially due to the use of 64-bit pointers (tend to be uniform in most cases.) This patch is developed to address that pending issue in D81925 <https://reviews.llvm.org/D81925>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109159/new/

https://reviews.llvm.org/D109159



More information about the llvm-commits mailing list