[PATCH] D109359: [TableGen] Optionally emit a warning for unused template args

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 06:23:39 PDT 2021


Paul-C-Anagnostopoulos added a comment.

(I've been scarce due to summer holidays and, sadly, real work.)

This is a great feature. Do we also need to add an 'unused' declaration that acknowledges the non-use of a template argument and suppresses the warning? Are there legitimate cases where an argument is passed but not used?

I think the test should include a couple of cases where the argument is used, to be sure that no warning is produced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109359/new/

https://reviews.llvm.org/D109359



More information about the llvm-commits mailing list