[PATCH] D109044: [DebugInfo][LoopStrengthReduction] Produce shorter expressions when using scev-based salvaging

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6237
+        if (Offset.getValue().getMinSignedBits() <= 64)
+          Changed |= RewriteDVIUsingOffset(DVIRec, *LSRInductionVar,
+                                           Offset.getValue().getSExtValue());
----------------
aprantl wrote:
> Does this mean the presence of debug info would change codegen?
No. I was using this return bool to check if debuginfo had changed, RewriteDVIUsingIterCount() has a similar return bool. However, the return values are currently unused. I will remove this return value for now as it seems its only use is to be possibly confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109044/new/

https://reviews.llvm.org/D109044