[PATCH] D106852: [SCEV] Fix getAddExpr for adding loop invariants into start of some AddRec

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

Just a side note (maybe not directly related to this one): the way how flags in SCEV are designed now (effectively set *after* SCEV construction is finished and later mutated) has been a source of subtleties and tricky bugs for a good while. I know it's hard, but maybe at some point we should just stop trying to do what we are doing now, and make SCEVs truly immutable. This will, in particular, prevent us from updating of flags of outer loop and fix this bug along with many other bugs of this variety.

This complexity just doesn't seem worth sustaining.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106852/new/

https://reviews.llvm.org/D106852