[PATCH] D108357: [AMDGPU][GlobalISel] Legalize memcpy family of intrinsics

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 6 22:30:12 PDT 2021


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:7936-7937
+  if (!LenVRegAndVal)
+    return UnableToLegalize; // Leave it to the legalizer to lower it to a
+                             // libcall.
+  uint64_t KnownLen = LenVRegAndVal->Value.getZExtValue();
----------------
This comment isn't accurate anymore now that the code lives in the legalizer as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108357/new/

https://reviews.llvm.org/D108357



More information about the llvm-commits mailing list