[PATCH] D109293: [JITLink][WIP] Add initial native TLS support to ELFNix platform

[luxufan via Phabricator via llvm-commits]

StephenFan added a comment.

In D109293#2984338 <https://reviews.llvm.org/D109293#2984338>, @lhames wrote:

>> To allocate the TLS descriptor in GOT, I need to get the edge kind information in PerGraphGOTAndPLTStubBuilder, So I add a Edge::Kind K argument in some functions in PerGraphGOTAndPLTStubBuilder.h. If it is not
>> suitable, I can think further to solve this problem.
>
> Is there a good reason to put these in the GOT? I would create and manage a different section for these, rather than re-using the GOT.

Put these in the GOT is not necessary. I agree with you that we need to create and manage a different section for these.

> Side note: Re-using the GOT in MachO is safe, but was a bit lazy. We could probably come up with a generic TableSection<T> utility that we could re-use for GOTs, PLTs, and these new thread data structures.

Emm, I don't know how to come up with a generic TableSection<T> utility. What does the generic type `T' represents?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109293/new/

https://reviews.llvm.org/D109293