[PATCH] D109054: [SImplifyCFG] Preserve knowledge about guarding condition by adding assume

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 6 21:58:23 PDT 2021


mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. Let's hold it for couple more days in case if someone has comments on it.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6604
+          else {
+            Value *Cond = BI->getCondition();
+            if (BI->getSuccessor(0) == BB)
----------------
Move the comment here; I'd simply say "Preserve knowledge about guarding condition by adding an assume because it might not be inferrable anymore".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109054/new/

https://reviews.llvm.org/D109054



More information about the llvm-commits mailing list