[PATCH] D108371: [LAA] Add Memory dependence and unknown bounds remarks.

Malhar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 6 19:25:16 PDT 2021


malharJ updated this revision to Diff 370983.
malharJ marked 4 inline comments as done.
malharJ added a comment.

1. Fixed the unit tests:
  - This required initializing the ORE object using one of the constructors: OptimizationRemarkEmitter(const Function& F)

  	  Previously several of the unit tests were hitting memory errors and
        they seem to have been fixed by this change.

- There are some minor formatting updates to the remark emitted.

2. Removed checks for loop distribution pragma remark from LIT tests. This is because there is no analysis being done to support it.

3. Updated recordAnalysis() to allow generating multiple reports when they are of the same type. This seems like a logical thing to do, for example if you have multiple instances of unbound array index case in a loop, it would be good for a user to view (in the report) similar types of errors and then correct them.

4. Updated LIT test to use new Pass Manager syntax

5. Minor formatting updates


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108371/new/

https://reviews.llvm.org/D108371

Files:
  llvm/include/llvm/Analysis/LoopAccessAnalysis.h
  llvm/lib/Analysis/LoopAccessAnalysis.cpp
  llvm/test/Analysis/LoopAccessAnalysis/memory-dep-remarks.ll
  llvm/test/Analysis/LoopAccessAnalysis/pointer-phis.ll
  llvm/test/Analysis/LoopAccessAnalysis/pointer-with-unknown-bounds.ll
  llvm/test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll
  llvm/test/Transforms/LoopVectorize/diag-with-hotness-info-2.ll
  llvm/test/Transforms/LoopVectorize/unsafe-dep-remark.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108371.370983.patch
Type: text/x-patch
Size: 36514 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210907/cabebd8b/attachment-0001.bin>


More information about the llvm-commits mailing list