[PATCH] D108961: [RISCV] MC relaxation for out-of-range conditional branch.

Mon Sep 6 18:45:28 PDT 2021

jrtc27 added a comment.

In D108961#2985805 <https://reviews.llvm.org/D108961#2985805>, @HsiangKai wrote:

> It is not a new feature for RISC-V. We already have `c.beqz` to `beq`, `c.bnez` to `bne`, `c.j` to `jal`, etc. This patch just extends the relaxation patterns to conditional branches. If MC relaxation is not a good idea, should we remove all the patterns in the `relaxInstruction` target hook?

My understanding is that's more a quirk of our implementation and is there to un-compress branches that get erroneously compressed (since a bare symbol is a valid operand for compressed branches), but yes, that does currently cause things to behave a bit strangely and ideally wouldn't be there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108961/new/

https://reviews.llvm.org/D108961