[PATCH] D109203: [X86] Don't clobber EBX in stackprobes

Elliot Saba via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 6 17:06:38 PDT 2021


staticfloat marked an inline comment as done.
staticfloat added a comment.

Tests expanded, and lint output applied.



================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:656
+  Register FinalStackProbed =
+      Uses64BitFramePtr ? X86::R11 : Is64Bit ? X86::R11D : X86::EAX;
   BuildMI(MBB, MBBI, DL, TII.get(TargetOpcode::COPY), FinalStackProbed)
----------------
pengfei wrote:
> Change to the format Lint suggested?
Funnily enough, the `arc diff HEAD~` command told me to lint it the old way.  Manually re-formatting (as I just did in my latest change) causes the local `arc` lint step to complain, but I overrode it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109203/new/

https://reviews.llvm.org/D109203



More information about the llvm-commits mailing list