[PATCH] D108283: [flang][driver] Add documentation for Plugins

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

This reads really well @stuartellis , thank you! I've left a few minor comments, but these are purely cosmetic, so accepting as is.

>From what I can see, all comments have been addressed. Let's wait a day or two before merging this in case other reviewers have more suggestions/questions.



================
Comment at: flang/docs/FlangDriver.md:289
+
+## Creating the Plugin
+There are three parts required for plugins to work:
----------------
Shouldn't this be `Creating a Plugin` (like in the top section)? I'm not a native speaker and might be wrong here.


================
Comment at: flang/docs/FlangDriver.md:301
+This subclass will wrap everything together and represent the `FrontendAction`
+corresponding to your plugin. It'll need to inherit from `PluginParseTreeAction`
+(defined in `flang/include/flang/FrontendActions.h`), in order to have access to
----------------



================
Comment at: flang/docs/FlangDriver.md:335-336
+struct ParseTreeVisitor {
+  template <typename A> bool Pre(const A&) { return true; }
+  template <typename A> void Post(const A &) {}
+  void Post(const Fortran::parser::FunctionStmt &f) {
----------------
[nit] It would be nice to keep these consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108283/new/

https://reviews.llvm.org/D108283