[PATCH] D108825: [yaml2obj] Allow variable number of directories

Alfonso Sanchez-Beato via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 6 10:00:42 PDT 2021


alfonsosanchezbeato marked 6 inline comments as done.
alfonsosanchezbeato added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/COFF/variable-number-rva.yaml:5
+
+# CHECK0:      NumberOfRvaAndSize: 0
+
----------------
jhenderson wrote:
> Does the `DataDirectory` list get printed (as an empty list) in this case? It would be good to test that if so.
It doesn't in this case (both for llvm-readobj and obj2yaml).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108825/new/

https://reviews.llvm.org/D108825



More information about the llvm-commits mailing list