[PATCH] D109323: [AArch64] Improve adrp schedule modelling on the Cortex-A55

Mon Sep 6 08:23:16 PDT 2021

NickGuy added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:3215
                            asm, pattern>,
-           Sched<[WriteLD]>;
+           Sched<[WriteLD, ReadAdrBase]>;

----------------
dmgreen wrote:
> This seems like a separate feature from adding FeatureFuseAddress for A55.
> 
> ReadAdrBase seems to be for the "base resister of a reg-offset LD/ST", where as this is the base register of a imm-offset LD/ST.
> Having a Read for this would sound useful, but it would probably be best for it to be on all Imm offset base registers, not just this one, and sounds like a separate change.
I've pulled it out of this change, and I'll push it up for review separately.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109323/new/

https://reviews.llvm.org/D109323