[PATCH] D107810: [ARM] Improve detection of fallthough when aligning blocks

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:360
     }
-    PrevCanFallthough = MBB.canFallThrough();
+    PrevCanFallthough = is_contained(MBB.successors(), MBB.getNextNode());
   }
----------------
samtebbs wrote:
> If my understanding is correct then the fall-through branch at the end of `MBB` isn't removed until the LowOverheadLoops pass. Do we therefore need to check if LOL are enabled?
Hmm. I was considering that all non-lob cases would already have been cleared up, handled by analyzeBranch, but perhaps you are right and this should be checking more specifically.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107810/new/

https://reviews.llvm.org/D107810