[PATCH] D109228: [AMDGPU][GlobalISel] Legalize G_MUL for non-standard types

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:364
+/// Widen the scalar type or vector element type for the given type index to \p Min
+/// or to the next multiple of \p Size, depending on which is greater (Min or Size).
+LegalizeMutation widenScalarOrEltToNextMultipleOf(unsigned TypeIdx,
----------------
The "depending on which is greater" part doesn't make much sense to me.

Either remove Min (here and in widenScalarToNextMultipleOf) or use the same wording as widenScalarToNextMultipleOf: "Widen ... to the next multiple of Size that is at least MinSize."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109228/new/

https://reviews.llvm.org/D109228