[PATCH] D45961: [MC] Add MCSubtargetInfo to MCAlignFragment

Mon Sep 6 07:08:59 PDT 2021

peter.smith added a comment.

In D45961#2983723 <https://reviews.llvm.org/D45961#2983723>, @MaskRay wrote:

> The diff was probably created by hand.
> `arc patch D45961` cannot apply this patch but `curl -L 'https://reviews.llvm.org/D45961?download=1' | patch -p0` can.
>
> https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
> It's a one-time setup. One it is set, the `arc diff 'HEAD^'` uploaded patch should be testable by builkite.
> See "Build Status" currently it cannot apply the patch https://buildkite.com/llvm-project/diff-checks/builds/62270#202c5d24-7b92-474c-aa62-b0e52e14fb56

Thanks for the comments, I've fixed them up locally and will give arc diff a try.

================
Comment at: llvm/include/llvm/MC/MCStreamer.h:450
   /// Create the default sections and set the initial one.
-  virtual void InitSections(bool NoExecStack);
+  virtual void InitSections(bool NoExecStack, const MCSubtargetInfo &STI);

----------------
MaskRay wrote:
> If `InitSections` is going to be changed, perhaps fix the case to `initSection`
Thanks for the suggestion, will do. I'll update on Friday when I'll have an update for D45962

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45961/new/

https://reviews.llvm.org/D45961