[PATCH] D109163: [AArch64][sve] Prevent incorrect function call on fixed width vector

[David Truby via Phabricator via llvm-commits]

DavidTruby updated this revision to Diff 370893.
DavidTruby added a comment.

Change test as suggested by @paulwalker-arm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109163/new/

https://reviews.llvm.org/D109163

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/sve-no-typesize-warnings.ll


Index: llvm/test/CodeGen/AArch64/sve-no-typesize-warnings.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/AArch64/sve-no-typesize-warnings.ll
@@ -0,0 +1,20 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s | FileCheck %s
+
+target triple = "aarch64-unknown-linux-gnu"
+
+define <4 x i32> @sve_no_typesize_warning(<vscale x 8 x i16> %a, <4 x i16> %b) #0 {
+; CHECK-LABEL: sve_no_typesize_warning:
+; CHECK:       // %bb.0:
+; CHECK-NEXT:    uaddl v0.4s, v0.4h, v1.4h
+; CHECK-NEXT:    ret
+%a.lo = call <4 x i16> @llvm.experimental.vector.extract.v4i16.nxv8i16(<vscale x 8 x i16> %a, i64 0)
+%a.lo.zext = zext <4 x i16> %a.lo to <4 x i32>
+%b.zext = zext <4 x i16> %b to <4 x i32>
+%add = add <4 x i32> %a.lo.zext, %b.zext
+ret <4 x i32> %add
+}
+
+declare <4 x i16> @llvm.experimental.vector.extract.v4i16.nxv8i16(<vscale x 8 x i16>, i64)
+
+attributes #0 = { "target-features"="+sve" }
Index: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
===================================================================
--- llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
+++ llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -13871,6 +13871,8 @@
     N = N.getOperand(0);
   if (N.getOpcode() != ISD::EXTRACT_SUBVECTOR)
     return false;
+  if (N.getOperand(0).getValueType().isScalableVector())
+    return false;
   return cast<ConstantSDNode>(N.getOperand(1))->getAPIntValue() ==
          N.getOperand(0).getValueType().getVectorNumElements() / 2;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109163.370893.patch
Type: text/x-patch
Size: 1556 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210906/4b1d68c1/attachment.bin>