[PATCH] D108371: [LAA] Add Memory dependence and unknown bounds remarks.

Mon Sep 6 03:49:22 PDT 2021

alban.bridonneau added a comment.

I quite like the way it looks with the code moved from the vectorizer to loop access analysis. I'll do a more in-depth review after the unit tests are fixed, but i left a couple of simple comments for now.

================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2083
   else {
-    recordAnalysis("UnsafeMemDep")
-        << "unsafe dependent memory operations in loop. Use "
----------------
why was this remark removed? As far as i can see, this message is not covered by the new memory report

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:889

-  if (!LAI->canVectorizeMemory())
+  if (!LAI->canVectorizeMemory()) {
     return false;
----------------
these braces can now be removed

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108371/new/

https://reviews.llvm.org/D108371