[PATCH] D109310: [NPM] Added -print-pipeline-passes print params for a few passes.

Markus Lavin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 6 03:47:31 PDT 2021


markus added a comment.

Obviously tests are needed but besides that is there anything fundamentally problematic about this patch?

I would consider this a shorter term hack and eventually we should unify the pass parameter parsing and parameter printing in some way. That way could be having a `PassParams` base class that one would derive from and register parameters. The base class would make sure that all registered parameters were both printable and parsable so that we could not end up in the situations where we forget to update the printing after adding a parsable parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109310/new/

https://reviews.llvm.org/D109310



More information about the llvm-commits mailing list