[PATCH] D105811: [flang][driver] Delete `f18` (i.e. the old Flang driver)

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: llvm/CMakeLists.txt:86
+    message(FATAL_ERROR "Clang is not enabled, but is required for the Flang driver")
   endif()
 endif()
----------------
mehdi_amini wrote:
> A few lines above, we enable MLIR automatically as a dependency of clang instead of erroring out, any reason you didn't just apply the same logic here?
This came up before. `LLVM_ENABLE_PROJECTS` is a `CACHE` variable (i.e. user variable), so we shouldn't modify it here. In https://reviews.llvm.org/D101842, @Meinersbur  suggested tweaking `LLVM_TOOL_*_BUILD` instead. See also this [[ https://reviews.llvm.org/D101842#inline-964091 | comment ]].

The lack of consistency in how the MLIR and CLang dependencies are treated is not great, but I've not had the bandwidth to fix this. Do you have a preferred approach here? I'm not a CMake expert - suggestions are very welcome! Btw, apologies for the delay, I was AFK for a couple of weeks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105811/new/

https://reviews.llvm.org/D105811