[PATCH] D109016: [llvm-objdump] Fix 'llvm-objdump -dr' for executables with relocations

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

One small suggestion, otherwise this looks fine.



================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs-exec.test:30
+    AddressAlign:    0x10
+    Content:         BF10004000E8FCFEFFFF90
+  - Name:            .rodata
----------------
Consider adding a leading `nop` too. You need to show that a relocation isn't printed before its correct location (in other words, the leading `nop` would have no associated relocation).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109016/new/

https://reviews.llvm.org/D109016