[PATCH] D109077: Do not attempt rematerialization with a killed register use

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 16:58:24 PDT 2021


rampitec added a comment.

I.e. rationale: when we do remat original instruction is still in place and one of its operands is killed. It is certainly either dead or VNI is different at the point of rematerialization, so it will not pass a check for "all uses are available". There is no even a point to report it can be rematerialized when an extensive check will say it is not. For the very same reason I was unable to create a test for it, it never happens.

@arsenm We may want to add this check for VOP, just to speedup RA a bit. This will be an extra work, however. Generic implementation scans operands anyway, so it is cheap, but we don't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109077/new/

https://reviews.llvm.org/D109077



More information about the llvm-commits mailing list