[PATCH] D109031: [AMDGPU] Introduce optimizeCompareInstr

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nit



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7974
+    } else if (MI.getOperand(1).isImm()) {
+      SrcReg2 = 0;
+      CmpValue = MI.getOperand(1).getImm();
----------------
Should use Register()


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7994
+    SrcReg = MI.getOperand(0).getReg();
+    SrcReg2 = 0;
+    CmpValue = MI.getOperand(1).getImm();
----------------
Register()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109031/new/

https://reviews.llvm.org/D109031