[PATCH] D109031: [AMDGPU] Introduce optimizeCompareInstr

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:8014-8015
+    // s_cmp_eq_i32 (s_and_b32 $src, 1), 1 => s_and_b32 $src, 1
+    // s_cmp_lt_u32 (s_and_b32 $src, 1), 1 => s_and_b32 $src, 1
+    // s_cmp_lt_i32 (s_and_b32 $src, 1), 1 => s_and_b32 $src, 1
+    // s_cmp_eq_u64 (s_and_b64 $src, 1), 1 => s_and_b64 $src, 1
----------------
foad wrote:
> These two should be `ge` instead of `lt`?
Thanks Jay, good catch!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109031/new/

https://reviews.llvm.org/D109031