[PATCH] D108951: [RegAlloc] Immediately delete dead instructions with live uses

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/LiveRangeEdit.cpp:369
     // allocations of the func are done.
-    if (isOrigDef && DeadRemats && TII.isTriviallyReMaterializable(*MI, AA)) {
+    // However, immedialtely delete instructions which have unshrunk virtual
+    // register uses. That may provoke RA to split an interval at the KILL
----------------
Typo: immedialtely => immediately


================
Comment at: llvm/test/CodeGen/X86/pr51655.mir:4
+# The test used to fail with "Live segment doesn't end at a valid instruction"
+# See PR51655.
+
----------------
Could you set a more descriptive file name like `delete-dead-instrs-with-live-uses.mir`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108951/new/

https://reviews.llvm.org/D108951